rgthree-comfy icon indicating copy to clipboard operation
rgthree-comfy copied to clipboard

Action button collector

Open mijuku233 opened this issue 1 year ago • 9 comments

I have an idea: add a node that collects fast action button for centralized control of action. It will highlight the most recently run action(Highlight the first action if no action has been run), like this

Screenshot 2023-10-15 205425

and can be set to a suspended panel, like this

Animation (5)

It would be better if you can add an animation for running action Animation (1)

mijuku233 avatar Oct 15 '23 13:10 mijuku233

A HUGE second for this. Would be a game changer for usability. If this request is too big, a second way would be to allow to collapse not just the inputs, but the choices below for those inputs as well. I want to connect many things to a single button, but that means the node is huge because of all the choices for connected nodes. And if I collapse the node, I lose the button.

barring that, a simple node that allows one to hook up many nodes, or via a connector, within a single Boolean mute/enable function on it. That way, I could disable whole parts of the workflow from one button of manageable size.

aegis72 avatar Oct 18 '23 04:10 aegis72

A lot of good ideas in here, I agree. Let me think about how to best achieve some of these.

rgthree avatar Oct 22 '23 13:10 rgthree

Modifying buttontext can simply implement ‘run animation and highlight’ send (3)

mijuku233 avatar Oct 22 '23 14:10 mijuku233

My workflow, AegisFlow, is already using a ton of RGThree nodes since they are so damn good :)

for my solution to the one button disconnect, I’m using fast muted and bypasser, which has allowed me to segment my execution to stages.

aegis72 avatar Oct 22 '23 18:10 aegis72

I still think that the "floating menu" aspect of this should remain. One of the issues is that, as the WF gets big/complex, if the user has to do a lot of settings located in different places. It would be REALLY cool if there could be a "floating group," that maintained its position and Z-ordered to the top, where one could place commonly needed elements---seed control, pos/neg conditioning, and switches (fastbypass/mute, etc). That way, the user could set most settings in one spot that they use while experimenting around, and just keep a nice big preview window to view results.

On a different note, a node that simply showed the currently executing node and its progress/state (ie, % done and green running / purple failed) would be awesome to place in a floating group like that.

aegis72 avatar Oct 23 '23 14:10 aegis72

I wonder if you guys have worked with unreal editor, specifically the material editor as their reroute nodes act as sort of a wireless access point which could be relevant in this case.

In the editor they have "Named Reroutes". Whatever you plug into a named rereoute node will be passed through to any of same named reroutes throughout the graph. Only the original reroute has a input noodle slot but all have output slots. Super useful for clean graphs where items get reused many times. I've included an image of the most basic setup of one for example. The purlople reroute node is outputing the Value 1.0 from both its own output slot & the purple samely named reroute node below it. image(5)

That being said I'm sure this isn't a trivial thing to setup. Along with this it can be easy to loose where you are using said named reroutes without a decent way to find them. 😉

Gerkinfeltser avatar Nov 30 '23 15:11 Gerkinfeltser

I wonder if you guys have worked with unreal editor, specifically the material editor as their reroute nodes act as sort of a wireless access point which could be relevant in this case.

In the editor they have "Named Reroutes". Whatever you plug into a named rereoute node will be passed through to any of same named reroutes throughout the graph. Only the original reroute has a input noodle slot but all have output slots. Super useful for clean graphs where items get reused many times. I've included an image of the most basic setup of one for example. The purlople reroute node is outputing the Value 1.0 from both its own output slot & the purple samely named reroute node below it. image(5)

That being said I'm sure this isn't a trivial thing to setup. Along with this it can be easy to loose where you are using said named reroutes without a decent way to find them. 😉

You can take a look at this custom node cg-use-everywhere

mijuku233 avatar Nov 30 '23 16:11 mijuku233

You can take a look at this custom node cg-use-everywhere

Great find! Thanks.

aegis72 avatar Nov 30 '23 16:11 aegis72

You can take a look at this custom node cg-use-everywhere

Errrmagarsh, awesome! Thanks for this!

Gerkinfeltser avatar Dec 01 '23 17:12 Gerkinfeltser