rgthree-comfy icon indicating copy to clipboard operation
rgthree-comfy copied to clipboard

[Feature Request] Binary Toggle Bypasser & muter

Open aegis72 opened this issue 1 year ago • 4 comments

See this use case: image

I have a segs upscaler WF that has at the front a WD14 tag interrogator. Ideally, the user would run that first, to get the "computer vision" interpretation of the input image. That way, they can get the base description for the basic pipe, which seems to help keep the image closer to the original.

As is, the fast bypasser has ALL the Segs-related nodes connected to a collector and repeater, leading to this switch. Because they are on two different items, they have to be switched independently. IE, on enter, the user has to select Enable on input 1 and disable on input 2.

Ideally, there would be a binary toggle that , when pushed, set 1-on 2-off and when pushed again reversed that (1-off, 2-on). I have this same need many places, where a user wants to do an option between two pathways, but it requires several clicks to do so.

Any interest in adding a fast muter/bypasser toggle? It wouldn't need to auto-build like they do currently, since it's a binary switch.

State one image

State two: image

aegis72 avatar Jan 18 '24 16:01 aegis72

Setup similar to another request, but about buttons, where two buttons are needed to do the job of one This setup is a bit easier to use, and is basically a machine with a start and stop button, instead of a more modern way that uses one button to control each function in succession https://forum.arduino.cc/t/controlling-2-leds-with-1-pushbutton-beginner/691854

image

This "works," but takes up WAY more room than it should

aegis72 avatar Jan 18 '24 16:01 aegis72

image

If the toggle isn't do-able...

aegis72 avatar Jan 18 '24 16:01 aegis72

So, this functionality kinda is there already, in two ways:

  1. In the Fast Muter properties, there's a toggleRestriction which you can set to always one. doing so, will only allow one entry to be toggled. With this set, when you go to toggle on an off toggle, the other toggle that is on will turn off. It's not an outright toggle, because if you try to turn off the one that's on, it just won't let you (since there needs to be one on, it just reacts but not letting you go to zero on). Screenshot 2024-01-18 215949

  2. Alternatively, or additionally, you can connect a Fast Actions Button to the Fast Muter and use the Toggle all option. That will flip all the toggles (and then resolve any toggleRestriction). Screenshot 2024-01-18 220102

The best option would be to do both of these. I'd add a toggleRestriction of "always one" to the Fast Muter, put it in an initial state, and then connect a Fast Actions Button with a single "Toggle all" and use that button to execute the switch.

rgthree avatar Jan 19 '24 03:01 rgthree

image

as an fyi, values aren't persisted when stored in template form, similar to how bypassers used to be. thanks for the tips.

aegis72 avatar Jan 22 '24 04:01 aegis72