Regis Gaughan, III
Regis Gaughan, III
I'm sure the new system is better than having nodes, though I've yet to check out the new reroute system (and don't have time to investigate right now). I don't...
So I just tried the new latest frontend and it looks like all of these are now "broken." Some comments: - From 1. above, I think a lot of (regular...
Addressed the non-null assertions and removed excess ones throughout. Consider pulling latest from https://github.com/rgthree/rgthree-comfy/commit/aa6c75a30b3ee8f01d7c9f8b0a126cccdc90616a
Thanks. Agreed and I actually do have code to do this locally, but the problem is all the lookup and key'ing is done by hashing the file; which can take...
Bummer. Not too surprising as Comfy continues to improve their codebase the risk of breaking rgthree-comfy increases. Can you file an issue with comfy frontend for visibility?
> The floating reroute can still be created the same way as before Awesome! @huchenlei @webfiltered though I think there's still a bug in the update that doesn't update not-fully-connected...
Also, @huchenlei @webfiltered, it looks like another bug in the update. Updating reroute nodes create a corrupt workflow (that then gets saved). Most of the time this can be kinda...
Okay, back to the filed issue: If you pull the latest rgthree-comfy your `Reroute (rgthree)` nodes' inputs and outputs will be positioned correctly! There's two issues I could not figure...
Thanks for the tip @webfiltered ! Looks like parentId is for native reroutes; maybe I'll extend the quick shortcuts to work for native ones too. But, what I was referencing...
Thanks for the PR, this is cool stuff. I can tell you've jumped in here and there's a lot of value you've added and I'm excited to see a contribution...