rgret-dev

Results 39 comments of rgret-dev

I'm not a huge fan of this change for the following reasons: 1. We lose the explicitness in code (e.g. `fill_with_random` vs `fill_with_secure_random`) 2. CSPRNGs are fast, but still more...

I don't find the loss of explicitness very tidy, that's all. If someone is skimming the code, it's much easier to see that it's using a dedicated CSPRNG rather than...

I'm not contesting that AK/Random currently has ifdef-soup or that its implementation uses CSPRNGs already. My final thoughts are: 1. We keep `SecureRandom` in LibCrypto (and implement any OS-specific things...

Also wanted to respond to what Jelle said: > drop RAND_bytes() in favor of a static_assert. I'd be interested to see if there are platforms out there where there's no...

URL parsing is failing here: https://github.com/LadybirdBrowser/ladybird/blob/a4463c45b9c8a44b0095351343bfe56afa7776eb/Libraries/LibURL/Parser.cpp#L545 Which I think is due to the invalid punycode host that it's trying to use: https://xn--mahboi.orca.pet

Confirmed, the `IDNA::to_ascii` function is getting a `UIDNA_ERROR_INVALID_ACE_LABEL` error from ICU which causes the parse failure.

I believe the site owner may have removed the problematic URL so now it's loading 😅 all my PR did was stop it from crashing but there was other errors....

> You could simply change the current directory before running the CLI for that same effect. You can, but this assumes that you're running Stryker from a "convenient" location, e.g....

Same with documentation updates to avoid an uptick in issues and/or people going to #build-problems on Discord 😅