starter-pack icon indicating copy to clipboard operation
starter-pack copied to clipboard

Enhancement: please include Dwarf Therapist

Open alanshutko opened this issue 6 years ago • 4 comments

alanshutko avatar Jul 22 '18 18:07 alanshutko

Hm, I’m surprised it wasn’t included automatically. I’ll try to debug the builder script. Sorry about that.

If there’s anything else missing, please file additional issues. Thanks.

rgov avatar Jul 23 '18 01:07 rgov

I believe it’s hardcoded as windows only in the json file.

On Jul 22, 2018, at 8:08 PM, Ryan Govostes [email protected] wrote:

Hm, I’m surprised it wasn’t included automatically. I’ll try to debug the builder script. Sorry about that.

If there’s anything else missing, please file additional issues. Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rgov/starter-pack/issues/6#issuecomment-406912263, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjTcUo6uU8Cerb3Ab3yCG2kwIiv3FTKks5uJSIlgaJpZM4VaGDO.

alanshutko avatar Jul 23 '18 01:07 alanshutko

FYI, I'm not sure what should be included, but I only get DFHack, DF, Soundsense and Legends Browser.

aljfdbgaliudhfbn avatar Jul 24 '18 17:07 aljfdbgaliudhfbn

Dwarf Therapist was probably disabled because it's shipped for Mac inside a .dmg file, which the starter pack build script couldn't open before I implemented that feature. However, I see that there is a bug stopping me from simply enabling it:

  File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/distutils/dir_util.py", line 126, in copy_tree
    names = os.listdir(src)
PermissionError: [Errno 13] Permission denied: '/var/folders/dy/0lgxvt4n0nb4c6h0sgq66bl80000gn/T/tmp21yw7vzn/.Trashes'

The DMG ships with a .Trashes directory that is not readable.

rgov avatar Jul 27 '18 01:07 rgov