svelte-headlessui icon indicating copy to clipboard operation
svelte-headlessui copied to clipboard

Published 20 hours ago • verified publisher icon rgossiaux

Implement DialogPanel?

Open ivarlovlie opened this issue 1 year ago • 18 comments

Headless ui has Dialog.Panel, I am unable to find it in svelte-headlessui. Is this because it is not implemented here, or am i missing something about the need for Dialog.Panel in this port?

Thanks!

ivarlovlie avatar Aug 22 '22 08:08 ivarlovlie

+1 for this

karmaral avatar Sep 09 '22 00:09 karmaral

I would be willing to invest time in a PR if there was documentation with pointers on how to port components. I haven't found it.

ivarlovlie avatar Sep 15 '22 02:09 ivarlovlie

My first pass on this seems to do the job, probably not production ready, but would love to make it so in a pr.

ivarlovlie avatar Oct 02 '22 07:10 ivarlovlie

@extremelygooddeveloper Unless there is a misunderstanding but the dialog panel is on the example page here https://svelte-headlessui.goss.io/docs/dialog

petr24 avatar Oct 14 '22 16:10 petr24

@petr24 Hmm, i only see these image

ivarlovlie avatar Oct 15 '22 06:10 ivarlovlie

Have no idea what page you're visiting, I go to the link on chrome and this is what you should see...

Screen Shot 2022-10-18 at 10 59 02 AM

petr24 avatar Oct 18 '22 17:10 petr24

Yes, there is no DialogPanel on that page.

ivarlovlie avatar Oct 20 '22 07:10 ivarlovlie

Well there is no "DialogPanel" in tailwind css or headless UI, it's called just "Dialog". I think this can be closed out.

petr24 avatar Oct 20 '22 15:10 petr24

Well there is no "DialogPanel" in tailwind css or headless UI, it's called just "Dialog". I think this can be closed out.

I mis-understood your question, and my answers were wrong. I see you were asking about "Dialog.Panel" with svelte variant being "DialogPanel", however I'm not sure it's necessary. I looked at the DOM for both headless UI example, and svelte headless UI, and it's the same. Parent Div with three children, h3, two divs. So it seems like this package has the function of Dialog.Panel without explicitly copying the headless UI api.

Svelte Headless UI Screen Shot 2022-10-20 at 8 08 55 AM

Headless UI Screen Shot 2022-10-20 at 8 14 59 AM

petr24 avatar Oct 20 '22 15:10 petr24