Richard Gomez

> I get nothing, because the above pre-supposes the remote will be called 'origin', mine is not, its called 'github'. Origin is the default remote name for cloned repositories (https://git-scm.com/book/en/v2/Git-Branching-Remote-Branches)....

Hey @pvillaverde, as you mentioned this looks like an unfortunate byproduct of #1598. Previously, generic-api-key's pattern only contained a subset of valid base-64 characters (`[a-z0-9=]`), causing it to miss a...

> I was a bit skeptical about the pattern, but I've been checking all my sealed secrets in a few projects and they do match that initial "Ag" that I...

> public interface IBingApi: IDistanceCalculationApi { Task Geocode(string address, string region); } Hey @DmitryMakarevich01, that appears to be a different issue relating to `generic-api-key`. Do you mind creating a separate...

Hopefully #1652 and #1665 reduce the likelihood of this occurring.

I think this can be closed now with #1676.

@bplaxco Just curious, are you able to run this change and share any new/common false-positives? My tweaking was solely done with positive cases, so there's no doubt bias in what's...

> Contains a run of characters Can you elaborate what you mean by this? It seems like the solution is to update the global allowlist to include things like `abcdefg`...

@zricethezav I've reverted the regex changes. I'll open separate PRs to gradually introduce the failing ones.

The solution could be making the quantifier lazy: `[\s\S-]*?`. https://github.com/gitleaks/gitleaks/blob/f361c5ef71853923277e3f284890083bc7825205/cmd/generate/config/rules/privatekey.go#L14