Raphael Geronimi
Raphael Geronimi
This is a great benchmark - will use it and publish sample measures for future reference
This fork has exactly the right fixes, rsolving this issue as well as 2 other pending issues: https://github.com/Mee6/python-ballpark
Outstanding work!
A complementary solution would be to have this exception have a specific type, e.g., TickerNotFoundError, to ease filtering. Currently it is an Exception which forces to perform some brittle string...
This would entirely rely on the bucket structure - no default bucket. For example to retrieve the key "ccc" from bucket "bbb" inside bucket "aaa", you would perform a Get("aaa",...
I have read your patch ( https://github.com/aio-libs/aiohttp-sse/pull/459/files ). However I am not sure it is safe. It assumes that, if the current task is cancelled, then it is due to...
I agree. Your code is much (much) more maintainable and forward-looking.
It looks like this refactoring would also allow to simplify the code of the `write_bytes` method underlying the `_writer` task: https://github.com/aio-libs/aiohttp/blob/006fbe03fede4eaa1eeba7b8393cbf4d63cb44b6/aiohttp/client_reqrep.py#L557 This method catches CancelledError which would be useless with...
Recent Python linters(e.g., Ruff, Flake8) are now complaining about the absence of the `strict=True` argument
Does it satisfy your quality criteria ? I was very careful with the code changes. Don't hesitate if your have any question. PS : for the future I think the...