atom-achievements icon indicating copy to clipboard operation
atom-achievements copied to clipboard

Number of achievements earned will affect startup time and memory usage

Open rgbkrk opened this issue 11 years ago • 4 comments

This may probably come as a no brainer but the more achievements someone earns the larger that unlockedAchievements object gets, which in turn gets serialized, which will increase the time it takes to load Atom.

I'm not sure how many it will take to cause real issues though it may be well out of the realm of real consideration.

rgbkrk avatar Mar 16 '14 02:03 rgbkrk

Can you load explicitly after activation?

smashwilson avatar Mar 16 '14 03:03 smashwilson

Yarp?

I guess we could load after the next achievement triggered or delay time before loading it using setTimeout.

rgbkrk avatar Mar 16 '14 03:03 rgbkrk

Stupid question here. Does any of Atom's javascript run in parallel? Would we need a semaphore around unlockedAchievements if we load after the first event fired?

rgbkrk avatar Mar 16 '14 03:03 rgbkrk

"Everything runs in parallel except your code."

rgbkrk avatar Mar 19 '14 00:03 rgbkrk