rgaudin

Results 844 comments of rgaudin

> * which tooling is appropriate (CircleCI?)? What's the value of CircleCI vs Github Actions in this case? Never used CircleCI… > * how do we test the Youtube player...

Understood. Here are my suggestion. None of them feel right though… `html` -> `html_parsing` `logging` -> `output` `rewriting.html` -> `rewriting.html_rewriting` (with corresponding changes for JS and CSS) `types` -> `content_types`...

- I find the v1 too different from the usual visual of kiwix-serve - I find both v2 and v3 to not convey the proper meaning. - I find the...

> [@rgaudin](https://github.com/rgaudin) [@benoit74](https://github.com/benoit74) I think we could implement v3 for 5xx like errors. What do you think? Absolutely. Just checked and neither 404 nor 500 responses uses templates. Both deserve...

Thank you ; I find v8 more readable with the white background and extended text. Feels like effort is given around helping sort out the issue. Would if be possible...

LGTM ; I dont mind the repetition. I think the title is more general information than a technical reason (where some subtleties might lie)

I'd like to stress that it sorta work by accident because most readers simply ignore the HTTP method of the request and return content from the ZIM using the request's...

I agree we should focus on use cases but for the sake of the argument, I don't see any difference between a POST and a DELETE. In both case, the...

Not to me. It's good to know it's possible this way but text should be selectable. We can't close this issue IMO. Doesn't mean it's a priority though.

The problem this is supposed to fix is not well defined IMO. Title mentions “missing links”, first line refers to “rewriting documents”. Failure in rewriting a link and rewriting a...