rgaudin

Results 844 comments of rgaudin

> Alternative suggestion: a refresh book endpoint which refresh only some ZIMs (to not be afraid of cost / time to completion) ; but this is maybe significantly harder to...

> > We make individual calls for each updated book for instance so the cache is only purged of gone entries. > > Ok, if this is a requirement we...

> > Alternative suggestion: a refresh book endpoint which refresh only some ZIMs (to not be afraid of cost / time to completion) ; but this is maybe significantly harder...

> it mention that it is possible to run warc2zim --help while this is both not working (you need to be inside the venv) + mostly useless (very few users...

Well the problem is not exposed clearly so it's difficult to respond. My understanding is that we have many warnings regarding stdlib code that we do not explicitly declare. This...

> > * `getIllustrationSizes` has not changed. It's a separate discussion but what's the decision on this? @kelson42 ? > > Aren't we going to deprecate the old API? Indeed,...

I like that the solution has a clear design and intent with those roles separate. The manager has a responsibility and if it's not running those can not be fulfilled...

Exactly. We could also imagine sending richer feedback than ping from manager to the API.

> **secrets are not passed to the runner when a workflow is triggered from a forked repository** What are you validating for if there's no secrets passing? The GH-correct way...