J Rob Gant

Results 109 comments of J Rob Gant

I wonder what is the difference is between `eslint-plugin-perfectionist` and `@eslint/js`, `globals`, and `typescript-eslint`? Because those all Goto Definition for me.

I'm trying to create a [demonstration app](https://github.com/rgant/brainfry) illustrating Angular, Firebase, and best practices. And I am running into this warning a bunch. So is there a better way to do...

@AE-0h Sorry to bother you but I am facing a similar issue as you did in [ask-cookbook.d.ts](https://github.com/inkonchain/docs/pull/280/files#diff-0edcbf0bb46662eac71ba8bf026268d01e9e42681a5043ee13470d808ba50ffdR1) with that error message. This seems to be the only other place on...

If interested I can open a PR to update the documentation with my fixes. However, it really does feel like `WithFieldValue` (and `PartialWithFieldValue`) are not correct and should be fixed.

> Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node) Link...

But then TypeScript doesn't understand that `date instanceof Date` is a [type guard](https://www.typescriptlang.org/docs/handbook/2/narrowing.html#instanceof-narrowing) for `WithFieldValue` which since it is just a type doesn't have a way to type guard that...

I tried adding another link to a repo to make the bot happy hopefully.

I think there are relatively few types that can both appear in a Firestore document and payload without erring. Could we add `Date | Timestamp` to the `Primitive` type? https://github.com/googleapis/nodejs-firestore/blob/c6c85b66a25b56bd23c19285302a740b0ca85d25/types/firestore.d.ts#L79...

It is my belief that `WithFieldValue` exists to allow you do do things like `serverTimestamp()` and `arrayUnion()`. Since `post.author = FieldValue.delete()` is a valid construct I don't have a problem...

I have come to the conclusion that this warning is not helpful and so I have used the [documentation](https://github.com/angular/angularfire/blob/main/docs/zones.md#logging) to silence the warnings. ```ts import { LogLevel, setLogLevel } from...