Gabor Retvari

Results 105 comments of Gabor Retvari

Can you please provide a bit more detail? Why I'm asking this is that the segfault occurs at a quite curious place: [`client.go:489`](https://github.com/pion/turn/blob/9ebb7c76ea4102ee4150556b257dc043cdb87bb7/client.go#L489C26-L489C40) contains this code: ``` case from.String() ==...

Sure, it's perfectly doable. Any thoughts on the client side API? How should we return the alt-server and alt-domain from `client.Allocate`? Or should we just merge this in ASAP and...

This makes a lot of sense. In Kubernetes we use API versions to handle breaking API changes: we release a new version (say, v1alpha2 on top of v1alpha1), an automatic...

I'm a bit reluctant to make users having to deal with super-low-level APIs like `stun.Message` but I don't have a better idea right now. What if we create a struct...

> The problem I see here is that we do not know the five-tuple at the time when `CreateAllocation` handler is called. Hence, the quota handler can not correlate the...

> I still need to understand why this works. This way, it seems like the client can not create multiple allocations using the same connection to the server as these...

Seems like a useful thing to add. Can you be a bit more specific though? What's the API? Where would we call the allocation handler, inside `server.CreateAllocation`? What would our...

Do you also want to handle the allocation quota case (as per point 7 above) in the same `AllocationHandler` callback, or it is intended only for signaling the `ALTERNATE-SERVER` response?...

Thanks a lot, this is a super-useful work! One suggestion: is it possible to rebase this PR to on top of #311? At least for me it'd be easier to...

First of all: thanks for this big chunk of code, the effort is truly appreciated! I've made a first pass and I concluded that I will need at least another...