Pylint alerts corrections as part of intervention experiment

[evidencebp]

I'd like to conduct a software engineering experiment regarding the benefit of Pylint  alerts removal. The experiment is described here. In the experiments, Pylint is used with some specific alerts, files are selected for intervention and control. After the interventions are done, one can wait and examine the results.

I'm asking for your approval for conducting the interventions in your repositories.The interventions are expected to benefit the project and will be submitted in PR for approval.

See examples of interventions in stanford-oval/storm, gabfl/vault, and coreruleset/coreruleset.

See the planed internetions.

Is it OK if I'll fix the alerts?

[evidencebp]

Specifically, in your Case I think that Pylint found few bugs. In misc\scripts\tuptime_modify.py, line 238 is if 'rntime' and 'slptime' and 'bootid' not in columns:

Pylint suggeted to simplify to "'bootid' not in columns" since 'rntime' and 'slptime' are considered to be True constants. The code does not check if they are in columns, which is probably what the developer planed. I noticed similar code in misc\scripts\tuptime_dbcheck.py, line 222

@rfmoz

[rfmoz]

Thank you for reaching out regarding your experiment. After considering the proposal, I would prefer not to have interventions applied to the repositories at this time. I appreciate your understanding.

[evidencebp]

Ok. Thnak you for notifying.