Riadh Fezzani
Riadh Fezzani
@grlee77, I resolved the conflicts for this PR. Any update from your side?
I agree, let's merge #5482 prior this PR and see then what is the best strategy to add the `num_iter` parameter :wink:
Sorry @alexdesiqueira, I forgot to push the `Comment` boutton :facepalm:: I converted this issue to a Discussion as we want to keep Issues for proper bug reports :wink:
I made some explorations, and found that the performance regression comes after #5062: ```python In [1]: import skimage In [2]: skimage.__version__ Out[2]: '0.18.0.dev0' In [3]: import imageio In [4]: from...
> I would prefer updating the docstrings for (current) `dilation`, `erosion`, ... with a note such as: "If you are using large circular structuring elements, you may be interested in...
Done, closing :wink:
Yes right! Sorry :pray:
Thank you @maldil for this PR! Usinging `grep -r "\.close(" skimage/`, I found ``` skimage/io/tests/test_sift.py: f.close() skimage/io/tests/test_sift.py: f.close() skimage/io/tests/test_sift.py: f.close() skimage/io/tests/test_sift.py: f.close() skimage/io/tests/test_sift.py: f.close() skimage/io/tests/test_simpleitk.py: f.close() skimage/io/tests/test_tifffile.py: f.close() skimage/io/tests/test_pil.py: f.close()...
Hi @maldil, thank you again for your time. The general scope of your PR is about using the context manager. The trickiest refactoring is the `io/sift.py` one, but all the...
Well, as you wish. No problem, I opened a PR to complete this. Thank you again @maldil