Reynir Björnsson

Results 143 comments of Reynir Björnsson

Originally reported in https://github.com/robur-coop/miragevpn/pull/279#discussion_r1778294852

Hey! No worries. After some thought this PR is not so important to me (my PR https://github.com/mirage/ocaml-cstruct/pull/316 would alleviate this anyway). So feel free to close it or let it...

It seems a quirk of rfc3986 relative references is that paths starting with an empty segment (`//...`) are not representable. The above tries to solve this by raising an exception...

A slightly annoying quirk of using a fresh `client` is that it would not keep track of the last remote tried. In some cases you want to retry the same...

It seems to me in this case we end up here with a timeout of `0L` and call `solo5_yield`: https://github.com/mirage/mirage-solo5/blob/0d9b87b344dbd10466c5b8bb87a3c46c0500968b/lib/main.ml#L51-L58 Then here I lose track of what happens (it calls...

Ok, it seems if you call timerfd_settime() with all zeroes it **disarms** the timer. I'll look into a fix in solo5 spt bindings...

So hvt had a similar issue: https://github.com/Solo5/solo5/pull/462/commits/97a66f6645499fafe77deadbce6d80c73641ea19 I tried applying the same fix in https://github.com/reynir/solo5/commit/683529bc97a355b471ba8227a159c0739f317a16 but in my test it doesn't seem to fix it - but then again when...

It was dune cache that was causing trouble...

When the URL starts with double slash it's a [Protocol-relative url](https://en.wikipedia.org/wiki/URL#prurl). In your example, `aaa` would be the authority and `/bbb` would be the path.

I think calling `Uri.path` is alright, but the issue lies at `Uri.of_string string` I think. My first idea was to use `Uri.make ~path:string ()`, but `string` is path *and* query....