drfp icon indicating copy to clipboard operation
drfp copied to clipboard

Add progress bar to encoder with `tqdm`

Open cthoyt opened this issue 4 years ago • 3 comments

I'm encoding the Rhea reactions with drfp right now and it's taking more than 10 seconds, so naturally I'd like to see how much longer it will take using a progress bar. This PR adds a progress bar with tqdm.

There was a strange bit of code before that I changed for _, x in enumerate(X): that didn't actually take advantage of the enumeration itself. This could have been replaced with iter(X) if the goal was just to turn it into an iterator, but also using tqdm gets the job done the same.

cthoyt avatar Aug 26 '21 16:08 cthoyt

Hey, I'm keeping the repo as-is until peer-review is done. (Yes, it's been a while ;-))

daenuprobst avatar Jan 07 '22 21:01 daenuprobst

@daenuprobst friendly reminder :) this is a short PR with nothing controversial

cthoyt avatar Feb 13 '22 17:02 cthoyt

@daenuprobst any chance of merging this now?

cthoyt avatar Sep 18 '22 16:09 cthoyt

Hey, I've added it to the latest release with other things I did. Finally ;-)

daenuprobst avatar Dec 28 '22 13:12 daenuprobst