httpd icon indicating copy to clipboard operation
httpd copied to clipboard

Ensure leading slash if path component is a directory

Open hrkfdn opened this issue 7 years ago • 5 comments

This fixes Werkzeug-based and possibly other applications using PATH_INFO.

CGI RFC3875 and PEP3333 state that PATH_INFO can be empty ("") or "/" for application root paths, but some applications (Werkzeug/Flask) expect it to be "/". This diff makes sure that this is the case. Werkzeug maintainers consider this to be an implementation mistake on httpd's side.

Followup discussions: https://github.com/reyk/httpd/issues/71 https://github.com/pallets/werkzeug/issues/1240

Fixes #71.

hrkfdn avatar Jan 21 '18 18:01 hrkfdn

@reyk: Have you seen this PR?

Neustradamus avatar Aug 04 '25 12:08 Neustradamus

There's no point in creating PRs on GitHub. This repository is outdated and no longer maintained by Reyk. @hrkfdn You should mail a diff to [email protected] if you want a review! I'd really love to see this be implemented

alenmeister avatar Aug 05 '25 15:08 alenmeister

Hey! I did bring it up on openbsd-tech. I was told to approach the Flask maintainers, but they disagreed. At that point I was too frustrated to push further.

hrkfdn avatar Aug 05 '25 15:08 hrkfdn

Ahh, damnit. Perhaps try your luck now with a little ping in the mailing list again?

alenmeister avatar Aug 05 '25 19:08 alenmeister

Ahh, damnit. Perhaps try your luck now with a little ping in the mailing list again?

Appreciate the encouragement :heart: But I don't use httpd anymore. Would still make me happy if this landed in tree 7 years later, though :smile:

hrkfdn avatar Aug 06 '25 09:08 hrkfdn