Pranshu Srivastava
Pranshu Srivastava
/hold Until https://github.com/kubernetes/kubernetes/pull/119949#discussion_r1294862644 is done.
Some thoughts around this. `client_golang` has exemplar support only for [`OpenMetrics`-format `Content-Type`](https://github.com/rexagod/common/blob/27a8fa5058d6a145c45fa4f75bec23ccc9fff448/expfmt/encode.go#L118-L165). However, [a discussion](https://cloud-native.slack.com/archives/C01AUBA4PFE/p1692293362079469) later pointed towards the fact that if we want to incorporate [protobuf negotiation functionality](https://github.com/prometheus/prometheus/pull/11448/commits/3cbf87b83d2a2278d776201cdd404cb9ce0884e1) to...
> Just to make sure, exemplar are also supported in proto format. Right, I should've been a bit more verbose here. It's not supported in `client_golang` but in `common`, which...
/remove-lifecycle rotten /lifecycle frozen This is something we plan on driving in the near future.
@dashpole Sorry if I missed something but I believe that's being targeted by https://github.com/kubernetes/kubernetes/pull/124013? If that's not the case, I'd be happy to add support for it. 🙂
/test pull-kubernetes-unit
Not sure why `pull-kubernetes-dependencies` is failing after pushing the `hack/update-vendor.sh` changes (as suggested [here](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119949/pull-kubernetes-dependencies/1829059284248301568#1:build-log.txt%3A777))? The other failing job seems to be flaking.
/test pull-kubernetes-e2e-gce
@dashpole Sorry for the re-ping, but it seems this needs an `/approve`d label as well.