angular-google-analytics icon indicating copy to clipboard operation
angular-google-analytics copied to clipboard

Published 20 hours ago • verified publisher icon revolunet

$stateChangeSuccess are now deprecated and disabled by default

Open hbdbim opened this issue 6 years ago • 6 comments

what now!?

https://ui-router.github.io/guide/ng1/migrate-to-1_0#state-change-events

hbdbim avatar Jan 18 '18 14:01 hbdbim

yep, we need some patch to handle that;

revolunet avatar Jan 19 '18 23:01 revolunet

Waiting for this too...

feelitloveit avatar Mar 02 '18 13:03 feelitloveit

@revolunet Perhaps it is time we stopped having ui-router (or ng-router) specific behaviors in the library and instead offer how to set it up as part of the documentation (it is pretty trivial stuff to setup). ui-router deprecating a feature should not require this library to update its version.

justinsa avatar Mar 05 '18 01:03 justinsa

Hi ! i cant really say whats good anymore as i dont use angular much..... but yes, if deprecated, we should to that 👍

revolunet avatar Mar 06 '18 14:03 revolunet

I am using the new version of ui-router (1.0.13 to be exact) and library is still operational. @hbdbim have you experienced / are you experiencing issues or you are only afraid you might do so in near future?

Rasha-Dj avatar Mar 20 '18 00:03 Rasha-Dj

Hello !

I had a related problem using ui-router 1.0.15. Nothing was sent to GA when changing page. Digging further, ui-router switched from

$stateChangeSuccess to $transitions.onSuccess

In the meantime I created a small working module inspired from :

https://dev.to/jordanirabor/using-google-analytics-with-angular-930

lsioctl avatar Jun 01 '18 08:06 lsioctl