angular-google-analytics icon indicating copy to clipboard operation
angular-google-analytics copied to clipboard

Published 20 hours ago • verified publisher icon revolunet

Change storage location of offline mode from in-memory array to localStroage

Open mohitt opened this issue 7 years ago • 1 comments

Hi,

Can I extend this module, to allow injection of the storage location of offline events. So, that as per the application need developer can inject. By default it would in-memory array only. So, that it stays backward compatible.

Let me know your thoughts.

Regards Mohit Thakral

mohitt avatar Jul 28 '17 08:07 mohitt

Do you want to extend it with localStorage and/or sessionStorage as per HTML5?

If you keep it fully backwards compatible, add an acceptable suite of unit tests, and ensure there is no requirement on another module / package, then absolutely. You just need to submit a PR for the change and I will be happy to code review, provide feedback, and assist you in getting the change in.

justinsa avatar Aug 01 '17 06:08 justinsa