angular-google-analytics icon indicating copy to clipboard operation
angular-google-analytics copied to clipboard

Published 20 hours ago • verified publisher icon revolunet

Angular 2.0

Open Toxantron opened this issue 9 years ago • 9 comments

Since angular 2.0 seems to be around the corner we might want to start developing a version 2.0 of the library on a branch. What do you think?

Toxantron avatar May 31 '16 13:05 Toxantron

Hi, I'm not much into Angular apps anymore so can't help here but maybe @justinsa @adam187 @deltaepsilon ?

revolunet avatar May 31 '16 14:05 revolunet

If they are interested we could create a branch ng-2 and start porting the module. I'd be happy to contribute via PR against the branch.

Toxantron avatar May 31 '16 14:05 Toxantron

I'm also doing react mainly react nowadays :(

adam187 avatar May 31 '16 14:05 adam187

Hopefully @justinsa is still on board. ;)

Toxantron avatar May 31 '16 14:05 Toxantron

I created a branch on my fork and will start porting to angular2 there. Anyone interested to join in is welcome. If this repo gets a branch I will open a PR.

Toxantron avatar May 31 '16 16:05 Toxantron

@Toxantron I may or may not get a chance to participate in this over the next two months.

justinsa avatar Jun 06 '16 16:06 justinsa

Would be nice to have you on board. The way I see it angular2 is still in beta and even after release I assume it will take some time before applications reach production state and require tracking.

And what would I do without your code reviews. ;)

Toxantron avatar Jun 07 '16 06:06 Toxantron

I am always happy to code review for you, just mention me in a comment on the code review and I will take a gander.

justinsa avatar Jun 09 '16 04:06 justinsa

Thanks. I think working with a sparing partner always yields better results. As soon as the branch approaches a state of migrating the libraries logic I will let you know.

Toxantron avatar Jun 09 '16 06:06 Toxantron