Breaking in Angular 1.4

[jeromechoo]

Ran a bower update and all carousel functions seem to stop working. After downgrading to Angular 1.2.28, everything works fine again. I'll see if I have some time to look into the issue. Nothing seems to come up on the error log at all.

[sckoh]

+1

nothing show up

[malfborger]

Is there a timeline for support for 1.4?

[jbarros35]

any workaround????

[revolunet]

Hey. No much time to work on this currently, sorry about that :/

My first guess is to check when happens here : https://github.com/revolunet/angular-carousel/blob/master/src/directives/rn-carousel.js#L161-L167 is the ng-repeat expression correctly parsed and valid ?

PR much appreciated (this repo is looking for contributors :))

[jeromechoo]

Dove into this and wasn't quite able to isolate the issue. Running with Google's CDN for Angular 1.4.1 (and the corresponding touch dependency), the carousel seems to work perfectly fine. Was anyone else able to isolate this issue at all?

[jbarros35]

I don't have enough knowledge on this for giving some help, most of us does not. We are javascript programmers not Angular engineers. By the way, I cannot test my application using Karma and Jasmine because its stuck on dependencies.

[revolunet]

I'm just a developer too :) What are the step to reproduce ? simply bower update?

[cedricblondeau]

Hi,

I just updated my app from Angular 1.2.8 to Angular 1.4.3 and the library works fine (angular-carousel 0.3.12).

If nothing shows up and if there is no JS errors after a simple bower update, I suggest that the library itself (angular-carousel) may have been upgraded as well (from 0.2.x to 0.3.x). Since version 0.3.0, li elements are absolutely positioned. So, the height CSS property has to be set manually on the ul element. If you don't do so, the ul element just won't show up. (see issue #309).

[revolunet]

Thanks @cedricblondeau

[dkirsanov]

Did someone hit the issue when swiping the pictures using cursor doesn't work? No problems with a touch swipe, only doing that by mouse. I'm using Angular 1.4.3

[dkirsanov]

If someone hit the issue described above, here is the solution: ul[rn-carousel] > li > img { -webkit-user-drag: none; }

[mhipo1364]

:+1:

[blockjon]

I'm using angular 1.4.5... the carousel does not work at all.

[anatoly314]

same issue as @blockjon , absolutely empty screen nothing being rendered

[kross-f]

@anatoly314 @blockjon Did you try adding height to ul tag ?

@cedricblondeau's fixed that for me (nothing rendered, no visible errors).

[anatoly314]

@kross-f , yes it was the issue. It wasn't clear from the manual that I should do it.

[zeeshanjan82]

Thanks @cedricblondeau you made my day. I was trying on angular 1.4 and after setting height everything worked fine

[jeromechoo]

+1 @kross-f Worked for me as well.