angular-carousel icon indicating copy to clipboard operation
angular-carousel copied to clipboard

Moving controls to templateCache

Open raphaelluchini opened this issue 9 years ago • 5 comments

Moving controls inline html to $templateCache to be possible overwrite them

raphaelluchini avatar Feb 25 '15 03:02 raphaelluchini

Hey, nice addition thanks, but looks like you didnt work on the last master version ? can you rebase please ?

revolunet avatar Feb 25 '15 08:02 revolunet

It's ok now?

raphaelluchini avatar Feb 25 '15 15:02 raphaelluchini

looks like some code is missing.

from your branch you should :

git remote add upstream https://github.com/revolunet/angular-carousel.git
git fetch upstream
git rebase upstream/master
git push

revolunet avatar Feb 25 '15 16:02 revolunet

Hello @revolunet, can you merge now? ;) Thanks

raphaelluchini avatar May 18 '15 16:05 raphaelluchini

looks like there is additional code, apart from the templateCache stuff ?

revolunet avatar May 20 '15 19:05 revolunet