revite icon indicating copy to clipboard operation
revite copied to clipboard

Published 20 hours ago • verified publisher icon revoltchat

fix(messages): don't attempt to display revolt wiki link as invite

Open infi opened this issue 2 years ago • 2 comments

  • [X] I understand and have followed the contribution guide
  • [X] I have tested my changes locally and they are working as intended
  • [X] These changes do not have any notable side effects on other Revolt projects
  • [X] ~~(optional) I have opened a pull request on the translation repository~~
  • [X] I have included screenshots to demonstrate my changes

Current Behavior

image

Expected Behavior Implemented by PR

image

infi avatar Mar 23 '22 20:03 infi

Actually, isn't the negative lookbehind unsupported in safari? I broke revite with this once

caniuse.com/js-regexp-lookbehind

Oh, can we check this first :trollface:

insertish avatar Mar 29 '22 19:03 insertish

Slightly hacky alternative to the lookbehind: make sure http(s):// appears directly before rvlt.gg

Rexogamer avatar May 07 '22 23:05 Rexogamer

(this is still broken) Closing due to rewrite, marking as potential issue in future by linking to https://github.com/revoltchat/frontend/issues/134.

insertish avatar Jan 24 '23 18:01 insertish