backend icon indicating copy to clipboard operation
backend copied to clipboard

feat(arm64): support for arm64

Open RedstoneWizard08 opened this issue 3 years ago • 7 comments

This PR is almost done! I'm just trying to solve compilation errors now. (Maybe it's the rust version, help wanted.)

This is a PR to add support for arm64 machines (again). It will compile Delta for arm64 and amd64 using a matrix and it will make sure they are published to the registry. (ghcr.io for now).

The motivation for this is that I have an arm64 server and I am not going to get an amd64 server. I would like to use Revolt on the server in production mode.

RedstoneWizard08 avatar Feb 10 '22 16:02 RedstoneWizard08

P.S. I may turn off fail-fast to allow matrix builds to continue even if one of them fails.

RedstoneWizard08 avatar Feb 10 '22 16:02 RedstoneWizard08

It worked! https://github.com/RedstoneWizard08/delta/actions/runs/1825689036

RedstoneWizard08 avatar Feb 22 '22 23:02 RedstoneWizard08

ARM builds take hours, this would need to be slightly tweaked to allow the amd64 image to build and push immediately, and only then or simultaneously (provided it doesn't slow it down), should the ARM image be built.

insertish avatar Apr 29 '22 16:04 insertish

This will likely need to be recreated due to the repo's restructuring - do you still want to work on this?

Rexogamer avatar Jun 02 '22 11:06 Rexogamer

This will likely need to be recreated due to the repo's restructuring - do you still want to work on this?

Sure!

RedstoneWizard08 avatar Jun 03 '22 01:06 RedstoneWizard08

ARM builds take hours, this would need to be slightly tweaked to allow the amd64 image to build and push immediately, and only then or simultaneously (provided it doesn't slow it down), should the ARM image be built.

What I plan on doing is caching a lot of the build, allowing it to only need to rebuild the parts that changed. I also plan to separate the AMD64 and ARM64 builds so that they can run asynchronously. Once both builds are done, a third will run to create a third image on the repository that merges the two layers.

RedstoneWizard08 avatar Jun 03 '22 04:06 RedstoneWizard08

And thank you rust for being slow (lol). (Rust is amazing, but it is pretty slow.)

RedstoneWizard08 avatar Jun 03 '22 04:06 RedstoneWizard08

Closing due to inactivity.

insertish avatar Jan 24 '23 20:01 insertish