revery icon indicating copy to clipboard operation
revery copied to clipboard

Published 20 hours ago • verified publisher icon revery-ui

Update .gitattributes

Open smorimoto opened this issue 4 years ago • 9 comments

smorimoto avatar Jan 18 '20 00:01 smorimoto

Which rei file is not marked as reason interface ? and we have some .re file that are marked as c++ so I don't think it is the right fix.

Et7f3 avatar Jan 18 '20 00:01 Et7f3

Linguist related changes take some time. Also, basically I should have changed re and rei at the same time in the previous PR, but I forgot about that so I updated it this time. (Even if it's correct at the moment, it's not a bad idea to force it in advance for the future.)

smorimoto avatar Jan 18 '20 00:01 smorimoto

It was merged 4 days ago :eyes: (it shouldn't be that long). I will wait .re file are marked as reason before merge.

Et7f3 avatar Jan 18 '20 00:01 Et7f3

Just out of curiosity, which code is marked as C++?

smorimoto avatar Jan 18 '20 00:01 smorimoto

image https://github.com/revery-ui/revery/search?l=C%2B%2B

Et7f3 avatar Jan 19 '20 22:01 Et7f3

I can at least confirm that when running linguist locally, the previous PR did fix the issue.

Before the previous PR:

image

After:

image

It must just be taking a while?

All the files that GitHub says are C++ are classed as Reason locally now.

CrossR avatar Jan 19 '20 23:01 CrossR

This was relatively quick for a small project, but it can take a while for a project of this size.

smorimoto avatar Jan 20 '20 00:01 smorimoto

@CrossR Is there some files with wrong language or we can merge.

Et7f3 avatar Jan 20 '20 08:01 Et7f3

I didn't see any Reason files that were being picked up as C++, or anything other than Reason from my look over.

CrossR avatar Jan 20 '20 10:01 CrossR