esy-skia icon indicating copy to clipboard operation
esy-skia copied to clipboard

Published 20 hours ago • verified publisher icon revery-ui

Feature/mac arm64

Open syaiful6 opened this issue 3 years ago • 4 comments

hi all, this PR allow us to build SKIA in Mac M1 without merging upstream repository, this is minimal changes required. Gn tool set default cpu to x86, so we need to set it to arm64 if it in Darwin.

This PR will also make current Revery compiled natively in M1. For Onivim2 there is small changes needed, but it just a path of homebrew prefix in M1 which is /opt/homebrew.

syaiful6 avatar Aug 08 '21 07:08 syaiful6

LGTM but I let owner of M1 approve and merge.

Et7f3 avatar Aug 08 '21 15:08 Et7f3

Wow what a hero! Thank you @syaiful6 for bringing over this set of changes to unblock the M1 build :heart_eyes:

bryphe avatar Aug 22 '21 19:08 bryphe

Hoping to see this get merged soon -- This was something like step 5 (and the last step) on a chain of pull requests to get various projects working on apple silicon devices, the other each wait on the next up until this one =]

taxilian avatar Oct 29 '21 04:10 taxilian

Wow, hoping to see this get merged as well. Is there anything I can do to help this move along - test on M1 or something?

fiddler avatar Feb 17 '22 10:02 fiddler