harmonium icon indicating copy to clipboard operation
harmonium copied to clipboard

MediaUploader - Allow updating of the accept prop

Open bryanjos opened this issue 6 years ago • 5 comments

I'm submitting a ...

  • [ ] bug report
  • [x] feature request
  • [ ] support request

What is the current behavior? MediaUploader sets the accept prop to image/*, video/*. https://github.com/revelrylabs/harmonium/blob/master/src/MediaUploader.js#L171

For bugs: please provide steps to reproduce and tell us a little about your environment (e.g., what OS and version of the package you're using)

give us enough information to properly diagnose the bug

What is the expected behavior? accept prop should be able to be set

For feature requests: why should the behavior change?

explain why your feature request is a good idea

Other information (we love stack traces!)

bryanjos avatar Dec 11 '18 17:12 bryanjos

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#accept

bryanjos avatar Dec 11 '18 17:12 bryanjos

Good catch - there's already a supportedFileTypes prop that takes an array of mimetypes so we should be able to use that to set accept on the input.

radditude avatar Dec 11 '18 17:12 radditude

~I'm gonna take care of this~ jk i'm not

CurtisVonRubenhoff avatar Dec 12 '18 17:12 CurtisVonRubenhoff

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

revelry-stalebot[bot] avatar Apr 01 '19 17:04 revelry-stalebot[bot]

forgot i was assigned to this and never did it. will take a look again next eng-meeting working session

CurtisVonRubenhoff avatar Jun 07 '19 15:06 CurtisVonRubenhoff