harmonium icon indicating copy to clipboard operation
harmonium copied to clipboard

As a user, I want fixes to the modal

Open blazebarsamian opened this issue 7 years ago • 3 comments

There are a few issues with the modal:

  • [ ] Modals need to have a way to close them. Add a close button.
  • [ ] Modals should not be opened by default. Default modals to be closed.
      • [ ] Need to add a clickToLaunch that opens the modal

IE11 Specific:

  • [ ] In IE11, the modal should remain in its container. Currently, it is being displayed as a full screen modal (which is how it would typically be displayed) but there's no way to close it in order to click a different component in the nav.

blazebarsamian avatar Jan 22 '18 19:01 blazebarsamian

Hello, I am looking into the Modal and quick questions:

  1. Revelry has a CloseButton, is it the design you would like? (There are different buttons designs available from Revelry, and this is convenient to include it as a props.children to the StatelessModal component to easily modify the close button design)
  2. When incorporating the StatelessModal, the isOpen props can be set as true or false (I see from your screenshot this is set to true). I am asking because I could not find a default option set to true, (set to props).
  3. The clickToLaunch should be set on which element? (The modal should open when clicking on a specific item right?) I am unsure where to add this (I have it on button in the example below)

Thank you very much! revelry

aurelieuno avatar Mar 01 '18 17:03 aurelieuno

@blazebarsamian Could you please confirm that the IE11 bug is fixed and close this issue if so?

jwietelmann avatar Oct 02 '18 17:10 jwietelmann

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

revelry-stalebot[bot] avatar Apr 01 '19 17:04 revelry-stalebot[bot]