ecto_soft_delete icon indicating copy to clipboard operation
ecto_soft_delete copied to clipboard

Include soft_deletable? check in with_undeleted function

Open rafaelofreitas opened this issue 2 years ago • 1 comments

This MR includes the following changes:

  • Include soft_deletable? check in with_undeleted function to filter only the records that have a deleted_at field.
  • Add support for Ecto.SubQuery in get_schema_module function to correctly identify the schema of a subquery.
  • Adds tests for the with_undeleted and soft_deletable? to ensure proper functionality.

This MR improves the ability to handle soft deletion in the application and increases the test coverage for these functions.

rafaelofreitas avatar Jan 19 '23 23:01 rafaelofreitas

FYI, there appears to be an issue with CI but it doesnt look like tests are actually failing

Dacello avatar Mar 01 '23 17:03 Dacello

Thank you! ❤️

stuartjohnpage avatar Jul 12 '24 16:07 stuartjohnpage