revault_tx icon indicating copy to clipboard operation
revault_tx copied to clipboard

Exhaustive parsing checks

Open darosior opened this issue 4 years ago • 4 comments

Right now, we only sanity-check the PSBTs in from_psbt_serialized() are sane with regard to our internal assumptions (unwrap()s basically). This may be enough, but we may also want complete parsing checks to be sure that whether a transaction is parsed or created with the constructor it will hold to our requirements (eg, no dust amounts, sane feerate, etc..). This is quite some more hairy code though..

darosior avatar Feb 27 '21 14:02 darosior

It includes checking the Miniscript s in the PSBT inputs too ...

darosior avatar Mar 02 '21 07:03 darosior

Part of this was implemented in #70 and #67

darosior avatar Mar 03 '21 10:03 darosior

This would include checking for duplicated inputs (found by the fuzzer in the Cosigning Server) and all sort of insane transaction in general.

darosior avatar Apr 28 '21 09:04 darosior

We need to refuse insane amounts as well, working on it.

darosior avatar Jul 09 '21 17:07 darosior