revault-gui icon indicating copy to clipboard operation
revault-gui copied to clipboard

ui: signer should check if the entered psbt has more signatures than the original

Open edouardparis opened this issue 4 years ago • 1 comments

From feedback: Also, can you check if the number of entries partial_sigs strictly increased and if not tell them that "No new signature was inserted in the PSBT" ?

edouardparis avatar Apr 05 '21 15:04 edouardparis

Note to the reader: it was in the context of a vault acknowledgement / activation. Conceptually we'd like to sanity check that the user did append their signature to the PSBT. Technically we cache the PSBT we sent them so we can check that the one they send back contains a new signature (partial_sigs field).

darosior avatar Apr 12 '21 05:04 darosior