revault-gui
revault-gui copied to clipboard
Display the fee amount explicitly
Right now they are implicitly deduced from the vault value and/or the detailed transaction screen
Can you elaborate where the fee amount should be displayed ?
This was a reminder of a discussion between you and @kloaec .
~~@edouardparis @darosior @kloaec can I have more context on this? Is the fee amount missing somewhere?~~
Antoine just clarified this to me: we do have the fees in the spend transaction displayed, we should display the Unvault fees as well
After https://github.com/revault/revault-gui/pull/133 we should probably separate between pure transaction fees, a concept users a re already familiar with and the overhead imposed by the architecture. How about having:
- The amount sent (#133)
- The overhead (Unvault CPFP output + Spend CPFP output + Unvault fee + Spend fee)
- The fee specific to each transaction, maybe as a small field in the transaction details, or maybe not at all for now
Partially covered in #133, we still need to update the fees in the spend view ("Total fees" which aren't total, see https://github.com/revault/revault-gui/pull/133#issuecomment-868344157)
split miner fee and change output