revault-gui icon indicating copy to clipboard operation
revault-gui copied to clipboard

Display the fee amount explicitly

Open darosior opened this issue 4 years ago • 6 comments

Right now they are implicitly deduced from the vault value and/or the detailed transaction screen

darosior avatar Apr 05 '21 07:04 darosior

Can you elaborate where the fee amount should be displayed ?

edouardparis avatar Apr 16 '21 10:04 edouardparis

This was a reminder of a discussion between you and @kloaec .

darosior avatar Apr 16 '21 10:04 darosior

~~@edouardparis @darosior @kloaec can I have more context on this? Is the fee amount missing somewhere?~~

Antoine just clarified this to me: we do have the fees in the spend transaction displayed, we should display the Unvault fees as well

danielabrozzoni avatar May 31 '21 16:05 danielabrozzoni

After https://github.com/revault/revault-gui/pull/133 we should probably separate between pure transaction fees, a concept users a re already familiar with and the overhead imposed by the architecture. How about having:

  • The amount sent (#133)
  • The overhead (Unvault CPFP output + Spend CPFP output + Unvault fee + Spend fee)
  • The fee specific to each transaction, maybe as a small field in the transaction details, or maybe not at all for now

darosior avatar Jun 18 '21 17:06 darosior

Partially covered in #133, we still need to update the fees in the spend view ("Total fees" which aren't total, see https://github.com/revault/revault-gui/pull/133#issuecomment-868344157)

danielabrozzoni avatar Jun 24 '21 13:06 danielabrozzoni

split miner fee and change output

edouardparis avatar Mar 10 '22 20:03 edouardparis