Robert (Bobby) Evans

Results 206 comments of Robert (Bobby) Evans

When I run the tests with this patch I still see an empty seen.txt on spark. @ivanliu what platform are you running on that has this all work?

@ivanliu that is the real problem we can run the benchmark but it does not really do anything and we are still trying to debug why that is.

Looking at the new docs for parsing strings to timestamps https://github.com/rapidsai/cudf/blob/e099e01c9b6ab8a2db5d5ee446b8843ee6199acc/cpp/include/cudf/strings/convert/convert_datetime.hpp#L62-L66 It looks like we might be able to convert SSS to %3f, because each S corresponds to a new...

@johnnyzhon > Are we going to support “MMMM" along with "SSS" ? > > !Expression date_format(timestampF#857, MMMM, Some(UTC)) cannot run on GPU because Failed to convert Unsupported word: MMMM null...

> If we want to add JNIs for them, should we put them in cudf or spark-rapids-jni? cudf. These are cudf APIs and we are not putting anything in that...

I think you want to use [GpuIf](https://github.com/NVIDIA/spark-rapids/blob/8d6f6f5cc115e44d3b6afcdf85f4207f35912a69/sql-plugin/src/main/scala/com/nvidia/spark/rapids/conditionalExpressions.scala#L180). It does the If/Else that you want. There does appear to be an optimized [replace_nans](https://github.com/rapidsai/cudf/blob/11d40a01064c9b4846e6db7d7b299350d0ba5074/cpp/include/cudf/replace.hpp#L138) operation in cudf that you could write a...

I took a look at the impala code and mode of it exists here. https://github.com/apache/impala/blob/da14fdcf35da28d2ff86c6ca9413a95cc3f8f346/be/src/util/tuple-row-compare.h https://github.com/apache/impala/blob/b28da054f3595bb92873433211438306fc22fbc7/be/src/util/tuple-row-compare.cc They don't manifest the zorder byte array. The number of bytes used for each...

It looks like deltalake has released zorder support to open source in versions 2.0 and above. The algorithm appears to be more complex than impala's, and very different. Delta will...

Oh I forgot to add that for some reason our DecimalGen does not currently generate negative numbers. I tried to fix this, but ran into this error.

This is for a runtime replaceable operator. So if we support RegExpExtract, then there is nothing more we need to do. We might want to add a test for RegExpSubString...