ng-inspector icon indicating copy to clipboard operation
ng-inspector copied to clipboard

Freezes/Crashes tab on ui-grid.info

Open DrewML opened this issue 10 years ago • 5 comments
trafficstars

http://ui-grid.info/

Steps to replicate:

  1. Visit page
  2. Trigger ng-inspector

This one has proven pretty difficult to debug so far, since the Chrome console crashes fairly frequently with the tab. I'm guessing it's a performance issue related to the amount of data the inspector probably needs to render on a page using multiple "grid" components, but that's purely speculation.

DrewML avatar Apr 07 '15 01:04 DrewML

This is super surprising to me - http://plnkr.co/edit/yLAIMZcvBLK9kBqDOzpx?p=preview

In that plnkr, a single record in ui-grid causes a huge performance issue. 3+ starts making the page unusable.

I'm going to try to dig into this one soon. This doesn't seem like the typical "big app" performance problems.

DrewML avatar Apr 11 '15 08:04 DrewML

I was having issues with errors being thrown in older versions of angular after #82, so I switched the detection to test if the definition of the directive is an array, otherwise annotate it in 9b35153.

For UI-Grid, the extension was throwing an error and displaying the infamous gray pane, but with this change it seems to work for me, and looks very performatic with your exemple.

rev087 avatar Apr 15 '15 00:04 rev087

I'm closing the issue, but please re-open if you're still having errors and/or performance issues.

rev087 avatar Apr 15 '15 00:04 rev087

Doesn't look like it's fixed, unfortunately :disappointed:

One thing I really dislike about plnkr: they always try to stick you within an iframe. Testing on the page you linked to is actually inspecting the plnkr app itself, not the example.

If you drill down into the iframe(http://run.plnkr.co/plunks/yLAIMZcvBLK9kBqDOzpx/), the same issue is still happening.

DrewML avatar Apr 27 '15 04:04 DrewML

Are you able to re-open the existing issue, or should I open up a new one?

DrewML avatar Apr 27 '15 04:04 DrewML