ng-inspector icon indicating copy to clipboard operation
ng-inspector copied to clipboard

Further issues barring entrance to the Mozilla Add-ons gallery

Open rev087 opened this issue 10 years ago • 8 comments
trafficstars

Your version was rejected because of the following problems:

  1. Dynamic creation of script nodes can be unsafe if contents are not static or are otherwise unsafe, or if src is remote. ng-inspector/data/inject.js 5
  2. The "mouseover", "mouseout" events are dispatched with high frequency and can cause performance issues. Use mutation observers instead https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver

Tested on Ubuntu 14.04 with Firefox v38

  1. is debatable, although we do create a script node, the contents are static and are not remote. What they consider unsafe exactly might be the bigger issue.
  2. could be solved by either the suggested method, or better yet (imo) using delegate events, which is a long overdue optimization either way.

rev087 avatar May 26 '15 13:05 rev087

Well, that's fun. Was this the first version you pushed a few weeks ago, or is this an update that they're rejecting?

DrewML avatar May 26 '15 14:05 DrewML

It's the second attempt. Took a while for them to review this time.

Getting in the extension gallery would be nice for the automatic updates, right now in the ng-inspector.org users can only download the .xpi directly :(

rev087 avatar May 26 '15 16:05 rev087

Damn -- sounds awfully similar to submitting iOS apps for Apple's approval.

DrewML avatar May 26 '15 16:05 DrewML

Yep! This exact thought popped up in my mind haha

rev087 avatar May 26 '15 16:05 rev087

Have these issues been fixed yet? I am no longer able to use the xpi from your websites due to further restrictions to the addon signing policy :(

Firefo 41.0a2 (2015-08-06) - i.e. newest Developer Edition

ng-inspector

eliihen avatar Aug 06 '15 13:08 eliihen

Hey @esphen,

Thanks for the heads-up. For the time being (work-around), it looks like you have the option in the stable and nightly builds to disable the requirement for addons to be signed.

We're hoping to dig deeper into the Firefox issues soon (both the rejection from the gallery, as well as the new code-signing requirements).

DrewML avatar Aug 06 '15 23:08 DrewML

Okay great, and thanks for the link! Please be advised that this workaround will only work until FF 41 hits stable, which is scheduled for 2015-09-22. Godspeed you guys!

eliihen avatar Aug 07 '15 06:08 eliihen

Let the race begin :)

As a side-note, we have recently discussed having a separate build for either a bookmarklet, or just a built JS file that you could include in a project during development to expose ng-inspector functionality, without worrying about browser extension restrictions (this would also allow us to support IE).

I'm pretty sure @rev087 and I are on the same page about desiring that functionality. Having said that, the "when" is still up in the air.

DrewML avatar Aug 07 '15 22:08 DrewML