columns_ui icon indicating copy to clipboard operation
columns_ui copied to clipboard

Add support for Default UI elements

Open mzso opened this issue 7 years ago • 12 comments

Hi!

There's quite a lack of good visualizations in the foobar realm. But Foobar has a few of them built-in. (Spectrogram, oscilloscope) It looks like DUI can use them, but columns ui can't

mzso avatar Apr 08 '17 11:04 mzso

They work in the Default UI and not Columns UI because they are Default UI elements but not Columns UI panels. Since they are closed source, it is difficult to change that.

A remaining option is to write a Columns UI panel that can host Default UI elements. It should be possible...

reupen avatar Apr 09 '17 12:04 reupen

@reupen commented on Apr 9, 2017, 2:16 PM GMT+2:

They work in the Default UI and not Columns UI because they are Default UI elements but not Columns UI panels. Since they are closed source, it is difficult to change that.

A remaining option is to write a Columns UI panel that can host Default UI elements. It should be possible...

I see. I expected the visualizations to be readily available to plugins in some form.

mzso avatar Apr 09 '17 13:04 mzso

I have no idea how feasible creating a CUI panel that could host DUI elements would be, but I'm sure many people would really like that option, including me.

Not being able to use stuff like Facets as part of my layout was always one of the few things that I wish could be improved. Obviously the option was always there for the developer to make said component CUI compatible, but at this point it probably won't happen, so a workaround like this would be welcomed.

Of course the development time might be better spent on simply improving CUI Filter Panels instead.

Daeron08 avatar Aug 27 '17 01:08 Daeron08

I don't think adding support for UI elements would be an unreasonable objective. You're right though in that it's probably be more useful to improve the Filters than add support for a a UI element that is no longer being developed.

Still, having some support for UI elements would still be useful for the built-in visualisations. There would be some questions about how seamless the integration would be though and whether it would only support whitelisted UI elements.

I'm planning on getting 0.6.0 beta 1 out soon (which will have some performance improvements but no major new features). After that I can start thinking about new features for 0.7.0.

reupen avatar Aug 27 '17 12:08 reupen

Is this and #41 within the realm of possibility of happening?

mzso avatar Jun 02 '19 11:06 mzso

Well, #41 is certainly easier.

Regarding this request, it's certainly possible on some level but the question would be how seamless the integration is. I except that the deeper the integration is, the more work it is going to be (if a seamless integration is even possible).

I think a non-seamless version of it could be attempted as a separate component. (That would probably look like: 'insert UI element, click Configure..., select a UI element.) We would certainly learn a lot by just attempting that (and, quite probably, someone that has written both a panel and a UI element would be better placed than me to attempt that).

In any case, my immediate priority is to finish the couple of things outstanding for 1.1.0 and release a beta of that.

reupen avatar Jun 04 '19 20:06 reupen

@reupen commented on 2019. jún. 4. 22:21 CEST:

Well, #41 is certainly easier.

Regarding this request, it's certainly possible on some level but the question would be how seamless the integration is. I except that the deeper the integration is, the more work it is going to be (if a seamless integration is even possible).

What do you mean by seamless? Built-in and plugin panels for DUI appearing like the rest of the CUI panels?

I think a non-seamless version of it could be attempted as a separate component. (That would probably look like: 'insert UI element, click Configure..., select a UI element.) We would certainly learn a lot by just attempting that (and, quite probably, someone that has written both a panel and a UI element would be better placed than me to attempt that).

I don't see a problem with this either internal or external. Add a DUI panel container, and the select it within which of the DUI panels I want.

In any case, my immediate priority is to finish the couple of things outstanding for 1.1.0 and release a beta of that.

Cool. It's nice that the project is active again.

mzso avatar Jun 06 '19 11:06 mzso

What do you mean by seamless? Built-in and plugin panels for DUI appearing like the rest of the CUI panels?

Yes, essentially that.

reupen avatar Jun 08 '19 20:06 reupen

voting for this issue)

djdron avatar Dec 09 '20 15:12 djdron

Any chances this will be implemented?

djdron avatar Jul 24 '22 17:07 djdron

It's none of my business but with fb2k v2, I can't help but think this request is a little redundant now. ReFacets and all DUI visualisations are available as CUI panels. With a lot more people wanting to use dark mode, the clamour for ye olde facets/simplaylist will be diminished.

And for active developers like @djdron , it's not much effort making your component support both. It's just shifting all common functionality in to a base class with a DUI element / CUI panel deriving from it.

marc2k3 avatar Sep 01 '22 11:09 marc2k3

@marc2k3 commented on 2022. szept. 1. 13:45 CEST:

It's none of my business but with fb2k v2, I can't help but think this request is a little redundant now. ReFacets and all DUI visualisations are available as CUI panels. With a lot more people wanting to use dark mode, the clamour for ye olde facets/simplaylist will be diminished.

And for active developers like @djdron , it's not much effort making your component support both. It's just shifting all common functionality in to a base class with a DUI element / CUI panel deriving from it.

I think there are a lot of old components on both side that don't support the other UI.

mzso avatar Sep 01 '22 13:09 mzso