wayverb icon indicating copy to clipboard operation
wayverb copied to clipboard

examples/audio_out.c patch does not apply

Open mcbaron opened this issue 6 years ago • 2 comments

macOS Mojave (10.14.6) on a 2018 MBP

download the release from master, open xcode project and build. The error appears as "patch failed: examples/audio_out.c:427" then "examples/audio_out.c: patch does not apply" below the compilation message "performing patch step for 'samplerate_external'."

I've tried changing the line in the samplerate_external.dir/build.make file to include the suggestions for git to ignore whitespace, however it seems that the build.make file is reconstructed with each xcode build. I've also tried applying the contents of the fix_carbon.patch file directly (it's the first patch under the samplerate_external heading in the build.make), and rebuilding to no avail.

mcbaron avatar Dec 02 '19 17:12 mcbaron

Having this issue too, @mcbaron did you ever find a solution/workaround?

shariq-audiofocus avatar Jul 16 '20 19:07 shariq-audiofocus

Found a workaround: Comment out Line #89 in config/dependencies.cmake. It appears that libsamplerate doesn't use Carbon anymore so the patch is not necessary.

PATCH_COMMAND ${GIT_EXECUTABLE} apply ${CMAKE_SOURCE_DIR}/config/fix_carbon.patch to # PATCH_COMMAND ${GIT_EXECUTABLE} apply ${CMAKE_SOURCE_DIR}/config/fix_carbon.patch

shariq-audiofocus avatar Jul 16 '20 19:07 shariq-audiofocus