retype icon indicating copy to clipboard operation
retype copied to clipboard

Unable to use certain SVG code in buttons

Open xyeLz opened this issue 3 years ago • 4 comments

In the Retype documentation it shows the possibility of using SVG code for icons within buttons. I was able to reproduce this with the code from Retype's documentation; however, I experience issues when doing this with other SVGs. For example:

[!button <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="black" class="bi bi-discord" viewBox="0 0 16 16"><path d="M13.545 2.907a13.227 13.227 0 0 0-3.257-1.011.05.05 0 0 0-.052.025c-.141.25-.297.577-.406.833a12.19 12.19 0 0 0-3.658 0 8.258 8.258 0 0 0-.412-.833.051.051 0 0 0-.052-.025c-1.125.194-2.22.534-3.257 1.011a.041.041 0 0 0-.021.018C.356 6.024-.213 9.047.066 12.032c.001.014.01.028.021.037a13.276 13.276 0 0 0 3.995 2.02.05.05 0 0 0 .056-.019c.308-.42.582-.863.818-1.329a.05.05 0 0 0-.01-.059.051.051 0 0 0-.018-.011 8.875 8.875 0 0 1-1.248-.595.05.05 0 0 1-.02-.066.051.051 0 0 1 .015-.019c.084-.063.168-.129.248-.195a.05.05 0 0 1 .051-.007c2.619 1.196 5.454 1.196 8.041 0a.052.052 0 0 1 .053.007c.08.066.164.132.248.195a.051.051 0 0 1-.004.085 8.254 8.254 0 0 1-1.249.594.05.05 0 0 0-.03.03.052.052 0 0 0 .003.041c.24.465.515.909.817 1.329a.05.05 0 0 0 .056.019 13.235 13.235 0 0 0 4.001-2.02.049.049 0 0 0 .021-.037c.334-3.451-.559-6.449-2.366-9.106a.034.034 0 0 0-.02-.019Zm-8.198 7.307c-.789 0-1.438-.724-1.438-1.612 0-.889.637-1.613 1.438-1.613.807 0 1.45.73 1.438 1.613 0 .888-.637 1.612-1.438 1.612Zm5.316 0c-.788 0-1.438-.724-1.438-1.612 0-.889.637-1.613 1.438-1.613.807 0 1.451.73 1.438 1.613 0 .888-.631 1.612-1.438 1.612Z"/></svg>]

The above code works normally unless you want to add any other context. For example, if you want to change the button size or add text, using the above code results in the button displaying the actual code visually rather than formatting the button. This also occurs with LinkedIn-generated SVG code.

xyeLz avatar Aug 29 '22 22:08 xyeLz

Can you share the code sample you are testing with that is not working? Just so I'm testing with the exact same code.

geoffreymcgill avatar Aug 29 '22 23:08 geoffreymcgill

Oh, sure. You can see the issue here: https://ccsp2022.alukos.com/

The URL is https://github.com/alukosdev/retypetest/blob/main/index.md and the entire page code sample is:


These notes were created and continue to be actively maintained by the Alukos team and the following members of the information security community:

Member | Social | Contribution
:--- | :---
Michael Ferullo (xyeLz#1337 on Discord) | [!button size="s" <svg width="24" height="24" fill="black" class="bi bi-linkedin" viewBox="0 0 16 16"><path d="M0 1.146C0 .513.526 0 1.175 0h13.65C15.474 0 16 .513 16 1.146v13.708c0 .633-.526 1.146-1.175 1.146H1.175C.526 16 0 15.487 0 14.854V1.146zm4.943 12.248V6.169H2.542v7.225h2.401zm-1.2-8.212c.837 0 1.358-.554 1.358-1.248-.015-.709-.52-1.248-1.342-1.248-.822 0-1.359.54-1.359 1.248 0 .694.521 1.248 1.327 1.248h.016zm4.908 8.212V9.359c0-.216.016-.432.08-.586.173-.431.568-.878 1.232-.878.869 0 1.216.662 1.216 1.634v3.865h2.401V9.25c0-2.22-1.184-3.252-2.764-3.252-1.274 0-1.845.7-2.165 1.193v.025h-.016a5.54 5.54 0 0 1 .016-.025V6.169h-2.4c.03.678 0 7.225 0 7.225h2.4z"/></svg>](https://linkedin.com/in/mjferullo) | Creator/Maintainer

## Errata

Please do not hesitate to contact me if you discover any pages containing inaccurate or outdated information, grammatical or spelling errors, and/or formatting issues.

xyeLz avatar Aug 30 '22 00:08 xyeLz

It kinda works if you treat the value as an icon attribute and change the " char to &quot;, but does not work for me if using text.

[!button size="s" icon="<svg xmlns=&quot;http://www.w3.org/2000/svg&quot; width=&quot;24&quot; height=&quot;24&quot; fill=&quot;black&quot; class=&quot;bi bi-discord&quot; viewBox=&quot;0 0 16 16&quot;><path d=&quot;M13.545 2.907a13.227 13.227 0 0 0-3.257-1.011.05.05 0 0 0-.052.025c-.141.25-.297.577-.406.833a12.19 12.19 0 0 0-3.658 0 8.258 8.258 0 0 0-.412-.833.051.051 0 0 0-.052-.025c-1.125.194-2.22.534-3.257 1.011a.041.041 0 0 0-.021.018C.356 6.024-.213 9.047.066 12.032c.001.014.01.028.021.037a13.276 13.276 0 0 0 3.995 2.02.05.05 0 0 0 .056-.019c.308-.42.582-.863.818-1.329a.05.05 0 0 0-.01-.059.051.051 0 0 0-.018-.011 8.875 8.875 0 0 1-1.248-.595.05.05 0 0 1-.02-.066.051.051 0 0 1 .015-.019c.084-.063.168-.129.248-.195a.05.05 0 0 1 .051-.007c2.619 1.196 5.454 1.196 8.041 0a.052.052 0 0 1 .053.007c.08.066.164.132.248.195a.051.051 0 0 1-.004.085 8.254 8.254 0 0 1-1.249.594.05.05 0 0 0-.03.03.052.052 0 0 0 .003.041c.24.465.515.909.817 1.329a.05.05 0 0 0 .056.019 13.235 13.235 0 0 0 4.001-2.02.049.049 0 0 0 .021-.037c.334-3.451-.559-6.449-2.366-9.106a.034.034 0 0 0-.02-.019Zm-8.198 7.307c-.789 0-1.438-.724-1.438-1.612 0-.889.637-1.613 1.438-1.613.807 0 1.45.73 1.438 1.613 0 .888-.637 1.612-1.438 1.612Zm5.316 0c-.788 0-1.438-.724-1.438-1.612 0-.889.637-1.613 1.438-1.613.807 0 1.451.73 1.438 1.613 0 .888-.631 1.612-1.438 1.612Z&quot;/></svg>"]

I'll see what we can do to support this functionality.

geoffreymcgill avatar Aug 31 '22 06:08 geoffreymcgill

That seemed to work for the aspects of the button component (for example, I could change the size and set the target to blank so it would open in another window) but after doing so, anything within the icon attribute aside from the SVG itself wasn't respected. For example, the icon was smaller than expected and the color was white despite being set to black.

xyeLz avatar Aug 31 '22 20:08 xyeLz