Markus Heiser

I can't edit (git push to) the PR .. Did you blocked this branch or is it because it is the master branch? For git push I missed this option:...

> sent an invite so you can make changes t :+1: > Just a quick thing if we're going to start doing caching Both consume resources; if the icons come...

> I'm getting a 500 Internal Server Error when trying to search. Sorry did a mistake when I implemented some compatibility stuff .. should now fixed / please try again.

Dear followers of this favicon PR, I'm sorry for my long absent on this topic. FYI: To continue I squashed the patches from the [WIP commit](https://github.com/searxng/searxng/commit/e63e83b1d1688201f338b01a0187c5a3c162ef7f) into their related commits....

As @Aetherinox already stated out, there is a bug .. when the cache is empty and a favicon provider does not serve a icon for a domain, we get this:...

> Not sure, but I think the issue is; when the client sends a icon request to the icon proxy and the icon resolver of the icon proxy is not...

> > The maintainer must be able to configure which resolvers are offered in the client (additional resolvers require additional resources) > > I don't think this is a feature...

FYI I pushed commit [33afea6](https://github.com/searxng/searxng/pull/3727/commits/33afea6f28baf2b72e691e551dc42ced9f6dd238) on top of this branch / read commit message to get the intention of this commit. The commit is still WIP and suffers some more...

> The transactions of a connection must be explicitly closed (commit) ... the `with` context apparently does not do `commit` / see [diff](https://github.com/searxng/searxng/compare/307c07c4d8c33a9fd64cfc4a090d53d53c72793b..1bf883bfcb367fd43ea6889e93d394957642c41f) Now I found out that the `with`...

FYI: We cannot rely on the resolver to return a valid favicon! ... here is one example wich returns a defective PNG: https://f1.allesedv.com/32/test-english.com Unfortunately, we also have no way of...