packetevents icon indicating copy to clipboard operation
packetevents copied to clipboard

Fixed IndexOutOfBoundsException for ClientPlayerDigging, ClientClientStatus, and ClientInteractEntity

Open DemonDxv opened this issue 2 months ago • 4 comments

DemonDxv avatar Oct 08 '25 20:10 DemonDxv

I'm not really a fan of adding yet more of these "UNKNOWN" enum states Idk what @retrooper thinks, but in my opinion making them nullable seems like a more appropiate solution then adding an enum value which doesn't actually exist

booky10 avatar Nov 03 '25 20:11 booky10

I actually like this approach. IMO it’s better to check if the enum is UNKNOWN than to handle nulls or exceptions. proto3 does something similar — it uses UNRECOGNIZED.

NoJokeFNA avatar Nov 04 '25 11:11 NoJokeFNA

I'm not really a fan of adding yet more of these "UNKNOWN" enum states Idk what @retrooper thinks, but in my opinion making them nullable seems like a more appropiate solution then adding an enum value which doesn't actually exist

I wouldn't of made this poll request if I didn't think it would benefit everyone, if you continue to leave it as is, people can just bot a server with pe 2.0 and send invalid packet data spamming the console with errors. I also noticed that even legit players get kicked and console error for these. One of the major ones was the TODO that i could not fix but since removed. Many legits kept erroring packetevents for index out of bounds based on the face value pe would read.

DemonDxv avatar Nov 04 '25 21:11 DemonDxv

Thanks for the PR.

retrooper avatar Nov 05 '25 07:11 retrooper