Signal languageChanged() now unnecessary

Open tanius opened this issue 5 years ago • 1 comments

It seems to me that the signal Trans::languageChanged(), declared in trans.h:25, is no longer needed now that Qt provides the QQmlEngine::retranslate() function.

The rest of this demo has already been modified to rely on QQmlEngine::retranslate(), and it seems that the signal Trans::languageChanged() is simply a remnant of the old code that has not yet been removed.

Nothing is broken, so no urgency here. Just if somebody is wondering what this signal is for …

Jul 26 '20 15:07 tanius

I don't remember why I kept it, but it might be because I wanted to leave the ability to subscribe to translation events.

Jul 26 '20 15:07 retifrav