magiclantern_simplified
magiclantern_simplified copied to clipboard
Published
20 hours ago •
reticulatedpines
reticulatedpines
Consider removing thread safety analysis work from crop_rec_4k code
crop_rec_4k_mlv_snd turns out to be another important branch that we want code from. In the normal pattern for ML development, this branch contains several different features, most unrelated to the branch name.
One such feature is a thread safety effort, utilising clang static analysis. See refs to REQUIRES, mutex.h and a new makefile target "tasks".
I think this works by invoking the build target, which triggers some kind of static analysis. I don't know if it's functional. I don't know if it's comprehensive. I don't know how to use or maintain it. Static analysis for thread safety is a cool concept, but I have no idea if this code is worth the maintainence cost.
Should we back out this feature?
