reticulatedpines
reticulatedpines
In module.c we have: ``` static module_entry_t module_list[MODULE_COUNT_MAX]; ``` MODULE_COUNT_MAX is 64, and a module_entry_t has several char arrays for various module name fields. Total size is 0x2d00, 11kB (see...
contrib was never a great name, it doesn't tell you anything about what it should do. Most things in there vaguely fit under "tools". Rename to that, and split out...
In raw.c we have: ``` 228 #ifdef CONFIG_DIGIC_V 229 #define RAW_TYPE_REGISTER 0xC0F37014 230 #define PREFERRED_RAW_TYPE 0x10 /* CCD; also valid for DIGIC 6 */ 231 #else 232 #define RAW_TYPE_REGISTER 0xC0F08114...
This is a useful summary of "how to dev safely" and should be added to the guide: https://www.magiclantern.fm/forum/index.php?topic=3624.0
CreateResLockEntry() returns LockEntry *. modules/edmac/edmac.c can do this in a loop due to find_free_edmac_channels(), and never frees it. LockEntry has pResources that is also allocated inside CreateResLockEntry(), of variable size...
Due to using mlv_set_type(), dual-iso module requires either one of mlv_lite or mlv_rec to be loaded. If only one module provided the symbol, it would auto-load. For that part, see...
Digic 5 is known to have fast (hw accel?) operations on buffers. These ops include subtraction: https://www.magiclantern.fm/forum/index.php?topic=13408.0 We could subtract raw video frames from a keyframe (every x-th? The prior?)...
We use "naked" on some functions, e.g. backtrace_getstr() (here, presumably to avoid disturbing register contents before doing the backtrace), but, GCC states: "While using extended asm or a mixture of...
Both mlv_lite and mlv_rec perform very similar functions. Functionality should be merged while keeping acceptable performance. If necessary, optional expensive functionality could be behind a toggle in a menu (metadata...
Both mlv_lite and silent modules list lossless.o as a dependency. mlv_lite/Makefile has it like this: `MODULE_OBJS=mlv_lite.o ../mlv_rec/mlv.o ../silent/lossless.o` This means if lossless.o is first built during silent module, and mlv_lite...