rethinkdb-desktop icon indicating copy to clipboard operation
rethinkdb-desktop copied to clipboard

Add connection list to all screens as collapsible side bar

Open oferitz opened this issue 6 years ago • 2 comments

oferitz avatar Jun 19 '18 21:06 oferitz

After taking a look on the current architecture, I believe the best way to accomplish this is making the connection list as part of the "Page", and creating a connection context which feeds all children inside a "Page"... The logical part will be on the context and the components will just show.

Add connection and edit connection becomes a modal

Besides the home screen when there are no connections saved, do we have any plans on having a page that won't have a sidebar with connection list? Or we will use the sidebar for anything else that isn't connection list?

Also, will the side bar, when open, affect the width of the content (like push it to the side) or will it be at the top? And when closed, do we want to show nothing at all but the button to open or some quick actions like database icons?

image

PierreAndreis avatar Jul 17 '18 00:07 PierreAndreis

@PierreAndreis Hi! Thanks for putting this together. Overall your suggestions make sense to me but here is my take on this:

Besides the home screen when there are no connections saved, do we have any plans on having a page that won't have a sidebar with connection list? Or we will use the sidebar for anything else that isn't connection list?

No. all pages should have access to the connection list, think about it like an app main menu which is always present across the entire app. I don't see any use case for side bar except for the connection list. I actually plan to remove the current home screen and make the Connection view as the home screen. the current home screen with the plus button was the first draft which doesn't make much sense now.

Also, will the side bar, when open, affect the width of the content (like push it to the side) or will it be at the top? And when closed, do we want to show nothing at all but the button to open or some quick actions like database icons?

In the new homepage the connection list is always visible but after you connected to some DB it should be collapsible side bar as overlay with the top DB icon trigger the open/close. similar to the slide example here.

Would you like to create a PR for that?

oferitz avatar Jul 18 '18 08:07 oferitz