Prettier pre-commit hook

[oferitz]

Create pre-commit hook to automate Prettier integration.

https://prettier.io/docs/en/precommit.html

[atris]

+1

On Wed, May 23, 2018 at 6:22 PM, Ofer Itzhaki [email protected] wrote:

Create pre-commit hook to automate prettier integration.

https://prettier.io/docs/en/precommit.html

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RebirthDB/electron-admin/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpO41Y75AG_ifvYzqhYqr_bDJF359ELks5t1VujgaJpZM4UKY3J .

-- Regards,

Atri l'apprenant

[thelinuxlich]

What do you think about StandardJS?

[oferitz]

@thelinuxlich i like StandardJS. in terms of style i set Prettier in the spirit of StandardJS, we can definitely use them together Prettier for code style and Standard for linting. it might require some non-trivial tweaking, but it's due-able.

[thelinuxlich]

Nice, I will do the same with the rethinkdbdash codebase.

[sagivf]

Not critical for me but I am +1 for StandardJS but -1 for Prettier. I find StandardJS saves time and merge conflicts but prettier does the opposite. At least that's been my experience.

[rodrigooler]

@oferitz @thelinuxlich @sagivf @atris I would like to start with this issue, to also go along with the project codebase.

It still keep the same logic of integrating prettier with standartjs?

[sagivf]

@rodrigooler Go head! :rocket: :rocket:

[PierreAndreis]

should this issue be closed?