horizon icon indicating copy to clipboard operation
horizon copied to clipboard

Published 20 hours ago • verified publisher icon rethinkdb

Add support for jsnext:main

Open simoncarpinter opened this issue 7 years ago • 3 comments

  • fix typo (jsnext:main, not jsmain:next)
  • include src/ in distributed version so that jsnext:main references a real artifact

This change is Reviewable

simoncarpinter avatar Sep 13 '16 09:09 simoncarpinter

Actually, scratch this. jsnext:main expects to find code that has been transpiled except for its module syntax. Artifacts in src/ are not transpiled.

simoncarpinter avatar Sep 13 '16 10:09 simoncarpinter

Hey, I think all we need to do is add an es6 output in compile.sh where we use the correct preset to transpile all but imports. Thanks for bringing this to our attention, I'll try getting it to work

deontologician avatar Sep 13 '16 23:09 deontologician

Awesome :). For reference, I realised this was problematic somewhere around 11pm NZT last night and figured I'd close it until I could hack on it a little further -- I meant to come back around to it sometime in the next couple of days after digging into how your compiling/webpack setup works :). If you're looking into it now then that saves me some digging in unfamiliar territory (I'll admit that JS build tooling is one of my least favourite parts of the ecosystem).

simoncarpinter avatar Sep 13 '16 23:09 simoncarpinter