Renaud Thiry
Renaud Thiry
In this version, being an admin is already sufficient to delete any message and attachment. The second commit is dropped. @robodoo r+
Fixed at [#47e9fa1e8e676387e53e4bf97d023468649755dd](https://github.com/odoo-dev/odoo/commit/47e9fa1e8e676387e53e4bf97d023468649755dd)
:eyes: @ryce-odoo Hi, sorry but I don't see a 17.3 PR Can't merge this without it as it will break the notification flow in stable otherwise. Feel free to DM...
@ryce-odoo don't forget to set forward port up to the version before https://github.com/odoo/odoo/pull/178142
You should have the right to set fw up to without r+ I don't have r+ rights anyway, no :/
> test_message_post From what I see it only adds one query because it has to do the "prepare" stuff once anyway, if you increase the number of recipients that use...
I think you meant to reference https://github.com/odoo-dev/odoo/commit/4c36d2d747b5f801917d74e9f0f83770e54fa3eb Otherwise seems legit but note that it reduces the number of selectable record in a batch at `if active_res_ids and len(active_res_ids)
I just meant you could replace it with a separate arbitrary limit, as it seems was done in https://github.com/odoo/odoo/pull/177334/commits/ac51f29f91e34cf4794164658a8c27d8b7759230 as strictly speaking it has nothing to do with the batch...
@odoo/rd-framework-editor fyi
Wasn't really sure where to fix it, found two places where it may make sense to fix generically (either one fixes the issue individually) Otherwise we can always force "pe-none"...