Peter Stenger

Results 177 comments of Peter Stenger

what song doesn't work?

I am going to close this unless you provide a link to an LRC site with the lyrics to the song. If no site exists, I obviously cannot download the...

If you could open a PR with that fix, that would be great. I no longer have a lot of time to maintain this library.

Can you provide the code used to generate this error.

What is `Config.PROXY`'s value

Ok, and finally what is the song you are using? I need this because I suspect the engine is having trouble with that specific song or case.

I see. https://www.syair.info/lyrics/modjo/lady/Ykx5VQ does not have valid LRC text. See the LRC regex we match against: ``` line_regex = re.compile(r'\[(?:(\d+):)?(\d+)(?:\.(\d+))?\]([^\[]+)') ``` Normally we get matches like this: ![image](https://user-images.githubusercontent.com/13869303/111214893-e18c4b80-85a8-11eb-9394-47b409e94280.png) And what...

What do you think the library should do when it sees a Lyrics File like this and cannot parse it?

I think I could change the return cases of the providers from: ``` return Lyrics(full_text) ``` to ```python3 try: return Lyrics(full_text) except InvalidLyricsException: return None ```

I will be able to implement that later this week.